Tank BIS is crafted acc's, that's a problem.

[AdamZ]

they adjust scaling every patch, there is no way to tell if it will be better because we will adjust the weight.

What do you mean by this? The actual sub stat weighting is not adjusted every patch? Every other patch we get a increase in ilvl and given how sub stats have difference scaling at different levels/amounts, the weights need to be adjusted as these change.

On tanks and crafted accessories, not like this is first time we have seen this. AR had tanks in crafted with STR/VIT melds. From 3.0 to 3.2 the i150 crafted and melded was considered BiS for progression, then had them mixed after that, if tanks did not want to do full STR.

3.2 I believe it was the crafted necklace was BiS if fully meled, given how bad the sub stats on both the i240 ones where.

Really, the only time crafted has not had at last some impact on BiS was 3.4 (and that is likely just cause we did not have 6's we could have put on them).

[Shinkyo]

The actual sub stat weighting is not adjusted every patch?

Crit is the exception because the scaling isn't linear.
Crit is currently so-so unless you can reach a combined DH+Crit of ~3500 which DPS class can barely exceed at fully melded i340. After that threshold, Crit gains in value relatively to other substats.
The future gear tiers will most likely favor Crit since you'll be able to reach higher values where it scales better than other stats.