Weaver or Goldsmith?

[Mikita]

In addition to what the others have said, Weaver really benefits from having Leatherworker leveled to the same level. In fact, I would say it's almost a necessity unless you want to constantly buy leather materials from the market board.

One step further, Leatherworker relies on drops from monsters (their skins) in order to make things, so unless you farm the materials yourself you are going to have to buy them off other people.

If your goal is to make gil (rather than making clothing, weapons, or armor for yourself or friends), I would level Goldsmith together with Miner, and produce HQ jewelry to sell on the market. These can provide decent income and can be created completely on your own with just these 2 classes.

Jewelry typically sells well because it can be spiritbonded, converted into materia, and replaced easily. Especially at endgame, weapons and armor tend to get valuable materia attached to them and not replaced so often.

It is possible to make money as a weaver, but it really helps to be on the leading edge of the wave and/or be able to farm all the materials yourself through Botany. This works for things like Linen (from Flax) or Twinthread (from Crawler Cocoons)... but you can run into materials shortages when you are working with Fleece and Snurble Tufts for Wool and Felt around level 40 to 50.

Just my experience from playing the markets for the past month with level 50 in all DoH and DoL except Armorer and Fisher.