Being a ShB baby myself I don't think I'm eligible to mention any older designs as I've never tried any of them firsthand.

Tank
  • PLD: ShB to 6.2
    As much as people meme the 'spreadsheet meme' revolving PLD pre 6.3, I really miss the alternating magic > physical phases.
  • WAR: ShB
    Nascent Flash design at its peak IMHO. Inner Release affecting ALL atks also allows funny interactions with BSF Lost Actions.
  • DRK: N/A (Pre-DT?)
    Too close to WAR overall. But I kinda miss Plunge so I guess pre-DT?
  • GNB: N/A
    Ain't my jam.

Healer
  • WHM, SCH, & AST: ShB
    I have ranted too much about them atp lol.
  • SGE: "Who..?"
    I don't know her.

Melee
I don't have much comment for all but NIN + I play them the least of all roles.
  • NIN: ShB
    Not a true melee. Flexible disengagement tools. My #1 fave of melee, even today.
  • SAM: ShB
  • MNK: N/A
  • DRG: ShB/EW
  • RPR: N/A
  • VPR: N/A
    Oh look! NIN's flexible disengagement tool cannibalized lmao.

Ranged
  • BRD: ShB
    The last time their DoT could proc repertoire like crazy. They did you dirty, Bard Pitt.
  • MCH: N/A
    Ain't my jam.
  • DNC: ShB
    Not a true long ranged dps. Remember 2 melee GCDs during flourish window? Remember saving Saber Dance in case you got too lucky with procs?

Caster
  • BLM: EW
    -Speechless-
  • SMN: ShB
    Mobile for good reasons when played proper while still able to compete with BLM reasonably.
  • RDM: ShB/EW
    Mixed bag, but it's hard to pick which one was my fave. DT didn't add anything interesting and had weird messaging such as how Grand Impact, Acceleration, and Jolt III implemented...
  • PCT: DT
    New guy. I love the colorful, vibrant aesthetic and flexible rotation without compromising the requirement to actually cast as a caster.