I'll throw my favorite iterations as well. I'll only list ones I have clear preferences on since I don't enjoy Tanks or Melees.

DNC: EW - This one's my main. I was resistant to the changes at first with them losing melee, but the other skills made up for it. And this version has a goofy Improv that you can double weave, so that's fun.
BRD: SB - The kit was tied to the dots better and didn't have too many finishers.
MCH: SB/EW - I liked both equally.

SMN: SB - The job felt really good and tied to aetherflow. We are sorely missing a dot mage after its death. I like EW SMN, but it does not compare to SB.
RDM: SHB/EW - Hard to say, RDM has not changed much outside of gaining finishers, change to mana, and change to aoe skills. It's core gameplay is mostly the same since SB and it was good then as it is now.
BLM: ARR - This one is funny, I just like ARR BLM most for the proc gameplay. But BLM has been good throughout the multiple expac series and is in a great place now.

WHM: SB - Barring the tacked on lillies, This was the best WHM as it had its dps skills and a trim effective healing kit. I enjoyed Cleric Stance in HW, but I can see why it was not a great thing for the game.
SCH: SB - The kits were again, more trimmed and efficient. And Deployment Tactics was nice to use with Eye for an Eye.
AST: SB - My main at the time. Just the best AST has been, outside of having to deal with Sleeve Draw shenanigans.