How to classify each Job.

[KDSilver]

Ninja has one combo with 2 different finisher indeed. But it's more a priority job than a pure combo job like drg.
You have to setup your suiton into trick attack and everything surrounding your burst windows which is not on your main combo.
Using your mudra frequently and refreshing your huton.

Sam is what we could also call "combo based" indeed, but it uses it to both refresh its buff and open its sen.

It's think jobs can't be classified this way.

Same for dancer.
Its both about proc and prority.
Dances, gcd proc, forced oGCG proc, feather, saber dance
Usage depend on your gauge, the buff aligment, if you're overcapping...

[Eloah]

Ninja has one combo with 2 different finisher indeed. But it's more a priority job than a pure combo job like drg.
You have to setup your suiton into trick attack and everything surrounding your burst windows which is not on your main combo.
Using your mudra frequently and refreshing your huton.

Sam is what we could also call "combo based" indeed, but it uses it to both refresh its buff and open its sen.

It's think jobs can't be classified this way.

Same for dancer.
Its both about proc and prority.
Dances, gcd proc, forced oGCG proc, feather, saber dance
Usage depend on your gauge, the buff aligment, if you're overcapping...

See that's interesting about Ninja. Prior to 5.1, I might of said Ninja was a Priority based job, but with Mudras being placed on the GCD, and being a type of combo, that's how I choose to classify them.

As for the way to classify them, that's really up to personal interpretation. For me it wasn't so much what produces the most damage, but what seems to form the basis of the jobs gameplay/what features stand out the most. That's why I said DoTs for BRD and SMN, even though at later levels they get more proc or priority skills. But those are just my thoughts. I am also aware that most jobs have a nice mix, so that they are not just 1 trick ponies.

Also I completely forgot to make a Pet classification. Though to be honest I feel at this point that is more of a sub class, given how we really only have "one" Pet class, since SCH and SMN are really just two sides of the same class.