Fishing in Shadowbringers seems to be pretty much a bust. Very few craftable fish, no aquarium fish that I have seen, and even the fishing retainer only lists about 5-6 items it can get - and only 2 of those are of any use.