What does it take to be considered a 'good' player?

[DiamondOrion]

go online and search up the rotation for the class you are using and that will make you a good player. Yes, ask for advice most players are helpful and be positive and accept criticism.

[Avenger]

go online and search up the rotation for the class you are using and that will make you a good player.

I find it rewarding, particularly if it's my main job, to first try to come up with my own rotation and see what is comfortable and seems to work well for the role. That can enable you to develop a practical understanding of the job skills and how they interact with each other, which is (for me at least) an interesting and enjoyable part of the game.

Regarding good players, the players I appreciate in PF and commend in DF:

1. Know how to hold hate, mitigate, and use cooldowns as tanks.
2. Keep people alive as a healer.
3. Do decent damage as DPS.
4. Execute battle mechanics correctly and avoid taking excessive damage.

and most importantly:

5. Are friendly and helpful without being overly critical.
6. Don't forget that it's a game that is supposed to be fun. ;-)