I support this. It would involve at least:

Gathering - miner & botanist
Crafting - blacksmith, carpenter & alchemist.

That would make it realistic when compared to real world fireworks & give five jobs something more to do. I can't see any reasons against it considering the models & actions are already in the game. If we include bottles of champagne (but calling it something other than what we have) we can include culinarian too.

As long as it's not a ridiculously expensive or locked craft then it's a great idea!