need advice on Warrior for 51 - 60, dungeon leveling, macros, etc. with controller?

[Dhex]

Macros are misused.

Never never never put multiple GCD skills on a macro & never put snap skills (Provoke) on a macro.

Macros with GCD skills have no action queue and can only be activated once your GCD has fully rotated and stopped.

The only useful macro is a toggle/hotbar swapping macro.

Toggle/Hotbar slot macro;

Preferred hotkey #1
/micon Defiance
/mlock
/ac Defiance
/hotbar ac "Defiance" "1" "12"
/hotbar ac "Inner Beast" "2" "11"
/hotbar ac "Steel Cyclone" "1" "11"


Preferred hotkey #2
/micon Deliverance
/mlock
/ac Deliverance
/hotbar action "Deliverance" "1" "12"
/hotbar action "Fell Cleave" "2" "11"
/hotbar action "Decimate" "1" "11"

What this set of toggles does is when you activate a stance (oGCD) via this macro it sets the corresponding stance abilities on your hotbars.

I would not use any of the macros you've listed they are incredibly inefficient and will make tanking harder rather than easier for you.