What makes a good tank in my opinion is first of all, damage mitigation. That's pretty self-explanatory. Second is, managing HATE/ENMITY. Third is awareness of battle and usage of appropriate Defensive Cooldowns in certain events. Lastly, positioning, it's essential where you place your enemy as it is needed to prevent unnecessary walks or runs to catch up certain raid/dungeon mechanics.