I've been "meh" about the whole thing, though I don't let it bother me because it's better than what WoW passes off for lore. The Scions do feel pretty throwaway to me, and I feel we've been cheated out of two actually interesting developments (one being Thancred during ARR, the other being Urianger in this latest patch). I also didn't like how they handled Moenbryda at all, but that's because I can't really care for a character that dies when I barely know them.
Then we hit the game's first loreLOL milestone, which was the resolution of the Ul'dah cliffhanger from 2.55. And yes, I'm comparing the resolution of that to
forest elves stealing space ships from alien goat people.
Heavensward was nice up until we hit the FF trope of disproving religion. I was expecting Heavensward to be about both sides of the dragon war before hitting the resolution to bring the war to an end, not the overused "the faith of a nation was built on a lie" thing. Don't get me wrong; I liked it back when it was used for Final Fantasy Tactics, but it's been almost 20 years since then and it's old to the point of being ridiculous. Still plenty of good moments, and I did like the fact that Ysaele, Estinien and Alphinaud actually felt like my companions over the course of the journey.
The warriors of darkness thing sounded cool, since I expected them to do their own thing as I was doing mine. Sort of like a rivalry where they'd be active in the world like I was. And then that got sacrificed to introduce a convoluted concept (the thing with the worlds, and the source world, etc) that reminds me too much of the negative aspects of Kingdom Hearts.