Sharpcast Buff Consumed If Applied Again Before a Thunder Spell Hits

Date & Time: December 23, 2021
Frequency: Always
World name: Leviathan
Character name: Haruna Astir
Class/Level: Black Mage, Level 90
Party or solo: Both
Area and coordinates: Anywhere

Steps:
1. Use Sharpcast.
2. Instantly cast any Thunder spell with any method: Swiftcast, Triplecast, or with the Thundercloud buff. Issue is most easily seen with Thunder III as that has the longest travel time.
3. Immediately use Sharpcast again as soon as the game will allow.
4. Although the first Sharpcast buff is properly consumed to force the Thundercloud buff to trigger, the second Sharpcast buff is erroneously removed and does nothing at all once the given Thunder spell hits and does damage.


I know there's another bug report about this, but this bug is actually a lot simpler than what that report is saying. The problem is simply that Sharpcast is being consumed both on cast and on hit when it should only be consumed on cast.

I recall that in ARR and early Heavensward, Black Mage elemental aspects and proc buffs applied on hit, but halfway through Heavensward, they were changed to apply on cast instead. I suspect that the old code of "apply/use on hit" has been needlessly left in for Sharpcast all this time and is only now causing a problem because the second charge of Sharpcast is brand new combined with the new 40s Thundercloud duration.